fix: do not send data to closed stream #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the following error: E5108: Error executing lua: Vim:Can't send data to closed stream stack traceback: [C]: in function 'chansend' /lua/telescope/previewers/term_previewer.lua:224: in function '_send_input' /lua/telescope/previewers/previewer.lua:85: in function 'send_input' /lua/telescope/previewers/term_previewer.lua:238: in function '_scroll_fn' /lua/telescope/previewers/previewer.lua:93: in function 'scroll_fn' /lua/telescope/actions/set.lua:249: in function 'run_replace_or_original' /lua/telescope/actions/mt.lua:65: in function 'scroll_previewer' /lua/telescope/actions/init.lua:222: in function 'run_replace_or_original' This happens when previewers.new_termopen_previewer()'s get_command() ends without pagination.
|
Good catch, thanks :) |
rameshsanth
pushed a commit
to rameshsanth/telescope.nvim
that referenced
this pull request
Nov 17, 2023
This commit fixes the following error: E5108: Error executing lua: Vim:Can't send data to closed stream stack traceback: [C]: in function 'chansend' /lua/telescope/previewers/term_previewer.lua:224: in function '_send_input' /lua/telescope/previewers/previewer.lua:85: in function 'send_input' /lua/telescope/previewers/term_previewer.lua:238: in function '_scroll_fn' /lua/telescope/previewers/previewer.lua:93: in function 'scroll_fn' /lua/telescope/actions/set.lua:249: in function 'run_replace_or_original' /lua/telescope/actions/mt.lua:65: in function 'scroll_previewer' /lua/telescope/actions/init.lua:222: in function 'run_replace_or_original' This happens when previewers.new_termopen_previewer()'s get_command() ends without pagination.
Conni2461
pushed a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes the following error: E5108: Error executing lua: Vim:Can't send data to closed stream stack traceback: [C]: in function 'chansend' /lua/telescope/previewers/term_previewer.lua:224: in function '_send_input' /lua/telescope/previewers/previewer.lua:85: in function 'send_input' /lua/telescope/previewers/term_previewer.lua:238: in function '_scroll_fn' /lua/telescope/previewers/previewer.lua:93: in function 'scroll_fn' /lua/telescope/actions/set.lua:249: in function 'run_replace_or_original' /lua/telescope/actions/mt.lua:65: in function 'scroll_previewer' /lua/telescope/actions/init.lua:222: in function 'run_replace_or_original' This happens when previewers.new_termopen_previewer()'s get_command() ends without pagination. (cherry picked from commit a62db88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the following error:
This error can be triggered using
new_termopen_previewer(), in case itsget_command()ends without pagination (full code) and then attempting to scroll down in the previewer.Type of change
How Has This Been Tested?
new_termopen_previewerandget_commandwhich returns a non-paginated output and attempt to scroll downConfiguration:
My full telescope config
Checklist: